Update to FCS36 (and the SynType.Paren AST node :horror:) #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jun 8, 2020
src/Fantomas/CodePrinter.fs
Outdated
| @@ -2395,7 +2395,10 @@ and genType astContext outerBracket t = | |||
|
|
|||
| fun (ctx:Context) -> | |||
| isShortExpression ctx.Config.MaxRecordWidth shortExpression longExpression ctx | |||
|
|
|||
| | TParen(innerT) -> | |||
| sepOpenT +> | |||
There was a problem hiding this comment.
in this case, to print a TParen, we render the parens around the rendering of the inner SynType.
jindraivanek
approved these changes
Jun 12, 2020
|
@baronfel, I released a new alpha with this: |
|
Thanks for finishing this up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has some second-order effects. The addition of the simple branch to
genTypefor wrapping the innerType of aSynType.Parenhas got several tests failling due to double-parens. This should just mean that the addition of parens in those special-cased situations needs to be removed, but that hasn't proven the case just yet.